fix v0 ref resolution #7415
fix v0 ref resolution #7415
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
| models = [node for node in all_nodes if node.resource_type == NodeType.Model] | ||
|
|
||
| # test v1 model | ||
| parsed_node_patch_v1 = models[0].patch.call_args_list[0][0][0] |
There was a problem hiding this comment.
Unfortunately not possible to test on the model nodes directly (e.g. models[0]) because these are MagicMock objects and parser.parse_file calls node.patch under the hood, which mocks the actual patching functionality. @gshank - We'd brought up moving the node.patch method to the PatchParser itself which would make the parsers more testable too - I'm working on opening a tech debt issue for it.
There was a problem hiding this comment.
Yes, another good reason to do it.
MichelleArk
requested review from
QMalcolm,
nathaniel-may and
gshank
and removed request for
nathaniel-may
| # if version is None | ||
| # else f"{str(resource_type)}.{package}.{name}.v{version}" |
There was a problem hiding this comment.
I know this PR is already merged, but did we mean to leave these commented?
If so, maybe we want to delete them altogether in a follow-up PR?
There was a problem hiding this comment.
oh no! I did mean to just rip those out. I'll clean it up in a follow-up PR
(cherry picked from commit 1722079)
resolves #7408
Description
Checklist
changie newto create a changelog entry